Use Swift 4 #28
Use Swift 4 #28
Conversation
Sources/Classes/Shari.swift
Outdated
| @@ -50,3 +66,4 @@ public extension ShariCompatible { | |||
|
|
|||
| extension UINavigationController: ShariCompatible { } | |||
| extension UITabBarController: ShariCompatible { } | |||
|
|
|||
There was a problem hiding this comment.
Trailing Newline Violation: Files should have a single trailing newline. (trailing_newline)
Sources/Classes/Shari.swift
Outdated
| return (sourceViewController, destinationViewController) | ||
| } | ||
| } | ||
|
|
||
| public extension ShariCompatible { | ||
|
|
||
| public static var si: Shari<Self>.Type { | ||
| get { |
There was a problem hiding this comment.
Implicit Getter Violation: Computed read-only properties should avoid using the get keyword. (implicit_getter)
Sources/Classes/ModalAnimator.swift
Outdated
| if ShouldTransformScaleDown { | ||
| transform = CATransform3DScale(transform, 0.95, 0.95, 1.0); | ||
| if ShariSettings.shouldTransformScaleDown { | ||
| transform = CATransform3DScale(transform, 0.90, 0.90, 1.0); |
There was a problem hiding this comment.
Trailing Semicolon Violation: Lines should not have trailing semicolons. (trailing_semicolon)
ShariTests/ShariTests.swift
Outdated
| } | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Vertical Whitespace Violation: Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)
| return (sourceViewController, destinationViewController) | ||
| } | ||
| } | ||
|
|
||
| public extension ShariCompatible { | ||
|
|
||
| public static var si: Shari<Self>.Type { |
There was a problem hiding this comment.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'si' (identifier_name)
| var si: CompatibleType { get } | ||
|
|
||
| static var si: Shari<CompatibleType>.Type { get } | ||
| var si: Shari<CompatibleType> { get } |
There was a problem hiding this comment.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'si' (identifier_name)
|
|
||
| public protocol ShariCompatible { | ||
| associatedtype CompatibleType | ||
| var si: CompatibleType { get } | ||
|
|
||
| static var si: Shari<CompatibleType>.Type { get } |
There was a problem hiding this comment.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'si' (identifier_name)
| public var BackgroundColorOfOverlayView: UIColor = { fatalError() }() | ||
|
|
||
| @available(*, unavailable, renamed: "ShariSettings.shouldTransformScaleDown") | ||
| public var ShouldTransformScaleDown: Bool = { fatalError() }() |
There was a problem hiding this comment.
Identifier Name Violation: Variable name should start with a lowercase character: 'ShouldTransformScaleDown' (identifier_name)
| public var BackgroundColorOfOverlayView = UIColor(red: 0, green: 0, blue: 0, alpha: 1.0) | ||
| public var ShouldTransformScaleDown = true | ||
| @available(*, unavailable, renamed: "ShariSettings.backgroundColorOfOverlayView") | ||
| public var BackgroundColorOfOverlayView: UIColor = { fatalError() }() |
There was a problem hiding this comment.
Identifier Name Violation: Variable name should start with a lowercase character: 'BackgroundColorOfOverlayView' (identifier_name)
| return; | ||
| } | ||
|
|
||
| let screenShotView = ModalAnimator.screenShotView(overlayView: overlayView) | ||
| let scale = self.map(value: location.y, inMin: 0, inMax: UIScreen.main.bounds.height, outMin: 0.9, outMax: 1.0) | ||
| let scale = self.map(value: location.y, inMin: 0, inMax: UIScreen.main.bounds.height, outMin: 0.7757, outMax: 1.0) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 122 characters (line_length)
No description provided.