Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDB output parsing security #70

Open
nakst opened this issue Feb 12, 2022 · 1 comment
Open

GDB output parsing security #70

nakst opened this issue Feb 12, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@nakst
Copy link
Owner

nakst commented Feb 12, 2022

When debugging untrusted executables running on a remote target, it may be possible for the executable may send malicious output that causes gf to behave unexpectedly in its parsing code. The parsing code needs to be checked/fuzzed/etc.

(When I was writing the GDB output parsing code, this was not a concern because I was only expecting to use it to debug trusted executables. But now that gf has grown in popularity this needs to be addressed.)

@nakst nakst added the bug Something isn't working label Feb 14, 2022
@nakst
Copy link
Owner Author

nakst commented Mar 31, 2022

EvaluateCommand

  • DebuggerGetStack
  • DebuggerGetBreakpoints
  • TabCompleterRun
  • gf-get-pwd
  • DisplaySetPosition
  • DisassemblyLoad
  • DisassemblyUpdateLine
  • SourceWindowUpdate -> autoPrintExpression
  • WatchChangeLoggerCreate
  • CommandWatchViewSourceAtAddress
  • RegistersWindowUpdate
  • ThreadWindowUpdate
  • ExecutableWindowStartOrRun

WatchEvaluate

  • WatchHasFields
  • WatchAddFields
  • WatchAddExpression
  • WatchGetAddress
  • CommandWatchAddEntryForAddress
  • CommandWatchSaveAsRecurse
  • WatchWindowMessage -> UI_MSG_PAINT
  • WatchWindowUpdate

EvaluateExpression

  • InspectCurrentLine
  • BitmapViewerGetBits
  • WatchLoggerUpdate

Update callback

  • SourceWindowUpdate
  • WatchLoggerUpdate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant