Skip to content

fix: review fixes v2 #2348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 25, 2025
Merged

fix: review fixes v2 #2348

merged 17 commits into from
Nov 25, 2025

Conversation

@neocybereth
Copy link
Collaborator

@neocybereth neocybereth commented Nov 25, 2025 •
edited
Loading

  • - Fix reward tooltips (only USDC is left)
  • - Shielded Transfer button should fill source address
  • - Sorting in staking modal is backwards
  • - Fix SelectToken.tsx search
  • - Destination address not clickable when source is empty
  • - Cancelling Keplr connection to chains reverts state
  • - OSMO/NAM occassionally not showing in Your Tokens
  • - Looking to Unshield tokens showing in Transfer animation
  • - Shield showing memo
  • - Add time last used on Recent Addresses
  • - Make CTA button reflect the action instead of just Submit
  • - Remove rogue transactions test

@neocybereth
fix: add addresses to shielded transfer button
36619e2
@neocybereth
fix: stakign table descending sorting shows opposite arrow
5fa7e0a
@neocybereth
fix: get filtering workig in selecttoken
cb5a4f1
@neocybereth
fix: cleanup looking to unshield section so it doesnt show during suc…
27cc26b 
…cess animation
@neocybereth
fix: show memo by default in shield
8abca1a
@neocybereth
fix: update rewards thresholds
0423d22
@neocybereth
fix: remove transactions header in transaction receipt and update wit…
c54f471 
…h success txn for recents
@neocybereth
fix: make CTA button on transfer module match flow
27f153c
@neocybereth
fix: destination address disabled when there was no source address
d019239
@neocybereth
fix: disconect keplr whenever user doesnt approve chains
1daccd5
@neocybereth
fix: remove filter on close
cb0af27
@neocybereth
fix: button CTA
6d262cb
@neocybereth
fix: clear filter when networks selected
3c8a9be
@neocybereth
fix: clear filters
619b58f
@neocybereth
fix: get transfer working
2b4240a
@neocybereth
fix: cleanup
1b96181
@neocybereth
fix: remove unshield during animation
1bec689
mateuszjasiuk
mateuszjasiuk approved these changes Nov 25, 2025
View reviewed changes
Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neocybereth neocybereth merged commit bd1f95b into main Nov 25, 2025
6 checks passed
@neocybereth neocybereth deleted the fix/review-fixes-v2 branch November 25, 2025 11:11
@github-actions github-actions bot mentioned this pull request Nov 25, 2025
Open
@mateuszjasiuk mateuszjasiuk mentioned this pull request Nov 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mateuszjasiuk mateuszjasiuk mateuszjasiuk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neocybereth @mateuszjasiuk