Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change language (please) #102

Closed
megosugit opened this issue Feb 14, 2022 · 11 comments
Closed

Change language (please) #102

megosugit opened this issue Feb 14, 2022 · 11 comments

Comments

@megosugit
Copy link

Hello,

at work, I have to use Windows 10 in French, however all my apps are installed in English as, most of the time, translations are not that great and when you search for something online, you'll always have better result in English.

I was trying to find a way to change OHT language in a .ini file or in the registry, and I then saw other requests here, which unfortunately you didn't agree with.

I can understand your point of view, however please remember such tool is used by advanced users, and it would be great to offer the choice to decide which language we would like (at least English).
I even set the English language during the installer, but in the end it didn't help with OHT once installed.

Most, if not all software gives this choice to the user. It would be really helpful if you can add this choice in OHT.

As you can see on this screenshot, the french translation makes things really ugly.
image

For all previous users requesting this (and all futures), pretty please, please consider this (small?) feature :)
If it is too much work, could it be added as a registry setting we would manually have to add ?
Something like:
HKEY_CURRENT_USER\Software\OpenHashTab
Localization_bypass = en-us

thank you for what is already a great tool :)
If you decide to give it a try, let me know if I can be of any assistance to test it ! I'll be glad to help.

Kind regards

@namazso
Copy link
Owner

namazso commented Feb 15, 2022

I might reconsider. Currently OpenHashTab is completely unaware of anything to do with localization, it's all Windows' doing, that's why it's not a "small" feature. But I also need to look into moving to MUIs instead of the Win9x localization mechanism that I'm currently using. If adding some sort of overriding feature doesn't seem like too much work I might do it.

@megosugit
Copy link
Author

thank you very much, this is a great news.
For now, I have edited the OpenHashTab.dll file and replaced all French strings by English ones. Not ideal but it seems to do the job, until I have to do it again next release :|

Thank you again for, at least, considering it. Hope is better than "no" :)

@yfdyh000
Copy link
Contributor

I might reconsider. Currently OpenHashTab is completely unaware of anything to do with localization, it's all Windows' doing, that's why it's not a "small" feature. But I also need to look into moving to MUIs instead of the Win9x localization mechanism that I'm currently using. If adding some sort of overriding feature doesn't seem like too much work I might do it.

Maybe the SetThreadPreferredUILanguages is useful.
Provide an "English UI" checkbox option will be the simplest, providing the Languages drop-down box will require some retrieval and works.

@namazso namazso closed this as completed in c1bb73d Mar 7, 2022
@namazso
Copy link
Owner

namazso commented Mar 7, 2022

Fixed in latest dev build. Add a DWORD named LangIdOverride to HKEY_CURRENT_USER\SOFTWARE\OpenHashTab with your preferred LCID

@megosugit
Copy link
Author

I forgot to say thank you.
I'll try when the next stable release is out. Many many thanks !

@megosugit
Copy link
Author

Fixed in latest dev build. Add a DWORD named LangIdOverride to HKEY_CURRENT_USER\SOFTWARE\OpenHashTab with your preferred LCID

just to be sure, if I want to force English US in the next release, should I use simply the value "1033" or is there another format like 0x0409 for instance ?

@namazso
Copy link
Owner

namazso commented Mar 22, 2022

It's a DWORD type, a number. The option in regedit to display it in hex or decimal is purely a display thing, it will result in the same value saved. And yes, 1033 is the correct value for English US

@megosugit
Copy link
Author

thank you, it is added and now ready for the next update :)

@vivadavid
Copy link

Hi,

I'd also find it useful to be able to change the language into English. Right now, it's in Spanish, and if I need to provide feedback, I need to figure out what original text in English said. Also, some of the translations are weird.

Thanks!

@namazso
Copy link
Owner

namazso commented Jul 6, 2023

@vivadavid This issue is already closed. Language changing was implemented, see Advanced features

I use it extensively for testing.

Also, some of the translations are weird.

Feel free to contribute, Weblate is open to all. Evidently, I don't know all 30 languages that the software was translated to. The extent of verification I do on translations is just Google Translate to see it's not completely fake.

@vivadavid
Copy link

Sorry, I didn't notice. I was just hoping it could be implemented without having to edit the registry, but I'll try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants