Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MUI_PAGE_LICENSE #9

Open
JeremyRand opened this issue May 25, 2017 · 6 comments
Open

Use MUI_PAGE_LICENSE #9

JeremyRand opened this issue May 25, 2017 · 6 comments

Comments

@JeremyRand
Copy link
Member

The current method of showing license information is non-standard. The correct/standard pattern for this in NSIS is to put this line between the MUI_PAGE_WELCOME and MUI_PAGE_DIRECTORY lines:

!insertmacro MUI_PAGE_LICENSE "ncdns_license.txt"

(ncdns_license.txt would presumably contain the text of the GPLv3+, as well as a preamble noting that Namecoin Core and Dnssec-Trigger have their own licenses.)

@hlandau
Copy link
Member

hlandau commented May 25, 2017

I did it this way for a reason. The MUI_PAGE_LICENSE option is for EULAs and constitutes an unnecessary nuisance to the user, as well as using an "I Agree" button to try and insinuate that some act of assent is mandated or can be inferred as having occurred as a result.

The way it's done here is simple and unobtrusive and avoids purporting to bind the user.

@JeremyRand
Copy link
Member Author

JeremyRand commented Jun 5, 2017 via email

@JeremyRand
Copy link
Member Author

Anyway, in an attempt to resolve this disagreement, I asked in #gnu about what the preferred method is.

J
Jeremy_Rand
On an unrelated note, it's not clear to me from https://www.gnu.org/licenses/gpl-howto.html what is the preferred method of disclosing the GPL to users of software that has an interactive installer, but is non-interactive once it's installed.
(For example, a Windows service that has an NSIS installer wizard.)
Is the preferred practice to have the installer show the text of the GPL, and make the user click "I agree" before the installer proceeds? Is it sufficient to simply say "This software is covered by GPLv3+" in one of the intro screens of the installer?
A
Anonymous (IRC)
either way is fine Jeremy_Rand[m] - you often see the GPL posed as an "Accept" "Decline" decision but there is really nothing for the user to "agree" with - especially with a binary only
i.e. the GPL places no terms on end-users unless they re-distribute
after the program is installed it should mention something in the "about" or "help" screen if it has one - even just a URL of to the license there
a standard short copyright notice
J
Jeremy_Rand
Anonymous: thanks, makes sense. Is it preferred to show the actual text of the GPL to the user, or is showing a URL sufficient, or is simply saying "GNU GPLv3+" (and figuring the user can Google for that) sufficient?
A
Anonymous (IRC)
in the instaler i would show the entire text
J
Jeremy_Rand
ok
I think that answers my question, thanks for the answer Anonymous
AA
Anonymous (IRC)
and copy the licence file onto the install location
J
Jeremy_Rand
ok

(Log edited to remove irrelevant conversation that happened simultaneously, and to anonymize the username of the person who answered my question.)

So, I'm willing to defer to the GNU folks about this:

  1. An "I agree" button is not necessary.
  2. The installer should show the full text of the GPLv3+ prior to install.
  3. The installer should copy the full text of the GPLv3+ to the install directory.

@JeremyRand
Copy link
Member Author

@hlandau looks like MUI_LICENSEPAGE_BUTTON can be used to replace the "I agree" button text. See https://nsis-dev.github.io/NSIS-Forums/html/t-363070.html . Does that meet your standards?

@JeremyRand
Copy link
Member Author

looks like MUI_LICENSEPAGE_BUTTON can be used to replace the "I agree" button text. See https://nsis-dev.github.io/NSIS-Forums/html/t-363070.html . Does that meet your standards?

@hlandau Ignoring the question of who actually codes the change, is this approach acceptable?

@JeremyRand
Copy link
Member Author

Noteworthy that VLC's Windows installer shows the full text of the GPLv2, with the text "You are now aware of your rights" below the text box that contains the full text. It uses the text "Next" rather than "I agree".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants