Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove queue consumer #542
The changes affect the
Additional changes included here:
Side-effects of this change are more connections to the RabbitMQ broker. In an ideal world, each entrypoint would maintain its own consumer but the channels and connections would be shared, but that requires more work and probably migration away from kombu. As implemented, we end up with a consumer, channel and connection for every queue from which we consume.
@kooba Thanks for the review. I will fix all the typos.
Yes, I think this should land in a v3.x.x release. It is compatible in terms of the external API, but I think the internal changes (e.g. many more rabbit connections) warrant a version bump.
I would also like to have upgraded kombu as part of the final 3.x release, but we can possibly make an alpha 3.x release to test beforehand.