New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hubot crashes on msg.send(null) when using irc adapter #5

Closed
xcolour opened this Issue Dec 7, 2011 · 3 comments

Comments

Projects
None yet
4 participants
@xcolour
Contributor

xcolour commented Dec 7, 2011

Should the adapter do nothing, or send an empty string in this case? I have a patch ready for both options (easy fix).

@mhemesath

This comment has been minimized.

Show comment
Hide comment
@mhemesath

mhemesath Dec 7, 2011

My vote is to say what null is.. nothing :-)

mhemesath commented Dec 7, 2011

My vote is to say what null is.. nothing :-)

@brunobord

This comment has been minimized.

Show comment
Hide comment
@brunobord

brunobord Dec 7, 2011

you can't send an empty string... that'd be nonsense. IMHO

brunobord commented Dec 7, 2011

you can't send an empty string... that'd be nonsense. IMHO

xcolour pushed a commit to DataDog/hubot-irc that referenced this issue Dec 7, 2011

tombell added a commit that referenced this issue Dec 7, 2011

Merge pull request #7 from DataDog/null_send
fix for #5: hard crash on sending null values
@xcolour

This comment has been minimized.

Show comment
Hide comment
@xcolour

xcolour Dec 7, 2011

Contributor

Okay, that's my vote too. See #7 for my pull request.

Contributor

xcolour commented Dec 7, 2011

Okay, that's my vote too. See #7 for my pull request.

@tombell tombell closed this Dec 7, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment