New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for better user identification for some IRC networks #17

Merged
merged 2 commits into from Apr 25, 2012

Conversation

Projects
None yet
2 participants
@FabianFrank
Contributor

FabianFrank commented Mar 24, 2012

hi guys,

I added a new environment variable that allows you to control the user part of the user@host string that hubot reports to the IRC server. some IRC servers, for example our internal one, check the user part to see if it is a valid user, might enforce the same user and nickname, etc. this patch allows us to use hubot in our IRC network and I hope others can benefit from it as well.

i am new to github and coffeescript, so any feedback is greatly appreciated. :-)

thanks,
fabian

FabianFrank added some commits Mar 24, 2012

hubot is identifying itself as user@host to the IRC server. making th…
…e user portion configurable as HUBOT_IRC_USERNAME, since certain IRC networks require a valid username instead of the default one, which is nodebot.
using options object for consistency
using options object for consistency, thanks jimeh for the suggestion.
@FabianFrank

This comment has been minimized.

Show comment
Hide comment
@FabianFrank

FabianFrank Apr 24, 2012

Contributor

Thanks a lot, I have updated the code as suggested. Hopefully we can pull it now? :-)

Contributor

FabianFrank commented Apr 24, 2012

Thanks a lot, I have updated the code as suggested. Hopefully we can pull it now? :-)

nandub added a commit that referenced this pull request Apr 25, 2012

Merge pull request #17 from Schnitz/master
allow for better user identification for some IRC networks

@nandub nandub merged commit a4c7262 into nandub:master Apr 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment