New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot connected event is not emitted from latest Hubot #18

Merged
merged 1 commit into from Apr 6, 2012

Conversation

Projects
None yet
3 participants
@getfatday
Contributor

getfatday commented Mar 26, 2012

It appears, since hubotio/hubot@93e8552 that scripts will not be loaded until a "connected" event is received.
As a result, hubot with the irc adapter will appear to be unresponsive.

The resolution was to add robot.emit "connected" to robot.run

Signed-off-by: Ian Anderson getfatday@gmail.com

Run now emits "connected" event in order to load hubot scripts
Signed-off-by: Ian Anderson <getfatday@gmail.com>
@cadwallion

This comment has been minimized.

Show comment
Hide comment
@cadwallion

cadwallion Apr 3, 2012

Any chance we could get this merged? It's blocking me and I'd rather not have to rollback hubot versions. :\

cadwallion commented Apr 3, 2012

Any chance we could get this merged? It's blocking me and I'd rather not have to rollback hubot versions. :\

@getfatday

This comment has been minimized.

Show comment
Hide comment
@getfatday

getfatday Apr 3, 2012

Contributor

For what it's worth, as a work around, I've adjusted my package.json to point to my repo until the issue has been resolved.

  "dependencies": {
    ...
    "hubot-irc": "git://github.com/getfatday/hubot-irc.git",
    ...
  }
Contributor

getfatday commented Apr 3, 2012

For what it's worth, as a work around, I've adjusted my package.json to point to my repo until the issue has been resolved.

  "dependencies": {
    ...
    "hubot-irc": "git://github.com/getfatday/hubot-irc.git",
    ...
  }
@cadwallion

This comment has been minimized.

Show comment
Hide comment
@cadwallion

cadwallion Apr 3, 2012

I had no idea you could give a git repo instead of a version. Will do. 🍺

cadwallion commented Apr 3, 2012

I had no idea you could give a git repo instead of a version. Will do. 🍺

nandub added a commit that referenced this pull request Apr 6, 2012

Closes #16, #18
Signed-off-by: Fernando Ortiz <fortiz2k@gmail.com>

@nandub nandub merged commit 40c0243 into nandub:master Apr 6, 2012

@nandub

This comment has been minimized.

Show comment
Hide comment
@nandub

nandub Apr 6, 2012

Owner

@getfatday Sorry it took this long to commit the changes. I'm not a coffee-script developer. Please test this and let me know.

Owner

nandub commented Apr 6, 2012

@getfatday Sorry it took this long to commit the changes. I'm not a coffee-script developer. Please test this and let me know.

@getfatday

This comment has been minimized.

Show comment
Hide comment
@getfatday

getfatday Apr 10, 2012

Contributor

@nandub No worries, I'm not either. Thanks for integrating the request. I tested it and everything looks good.

Contributor

getfatday commented Apr 10, 2012

@nandub No worries, I'm not either. Thanks for integrating the request. I tested it and everything looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment