Rt 120862 no dot in default inc #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for noticing my oversight. Much appreciated. |
kentfredric
reviewed
Jun 19, 2017
| @@ -8,6 +8,7 @@ use ExtUtils::MakeMaker; | |||
| use File::Spec::Functions qw( catfile rel2abs ); | |||
| use Getopt::Long qw( GetOptionsFromArray ); | |||
|
|
|||
| push @INC, '.'; | |||
| unless( require( catfile qw(inc IO Interactive Tiny.pm) ) ) { | |||
There was a problem hiding this comment.
Surely, the right thing to do here would be to augment the call to "require" to start with "./", as modifying @INC for the entirety of Makefile.PL is not actually necessary here.
|
Honestly, both this and #5 are ... well. Weird. Especially given the more obvious, safe, and logical answer alternative is: diff --git a/Makefile.PL b/Makefile.PL
index fcc3a7d..937789a 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -8,7 +8,8 @@ use Getopt::Long qw( GetOptionsFromArray );
use Path::Class;
use Try::Tiny;
-use inc::IO::Interactive::Tiny;
+use lib 'inc';
+use IO::Interactive::Tiny;
caller
or run(\@ARGV, [qw{ssl crypto ssl32 ssleay32 eay32 libeay32 z}]);
--
2.13.1Why all the special tricks? |
this works for me, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.