Skip to content
Permalink
Browse files

fix(electron): don't use has-own-prop to check signature header

  • Loading branch information...
devinus committed Dec 21, 2018
1 parent e521b7d commit 0db33800792eb59379a5e8103c60e8177cb801a9
Showing with 6 additions and 13 deletions.
  1. +3 −4 ember-electron/assets.js
  2. +2 −3 package.json
  3. +1 −6 yarn.lock
@@ -2,6 +2,8 @@ const path = require('path');
const crypto = require('crypto');

const got = require('got');
const prettyMs = require('pretty-ms');

const lzma = require('lzma-native');
const tar = require('tar-fs');
const tarStream = require('tar-stream');
@@ -11,9 +13,6 @@ const del = require('del');
const cpy = require('cpy');
const makeDir = require('make-dir');

const prettyMs = require('pretty-ms');
const hasOwnProp = require('has-own-prop');

const Promise = require('bluebird');
const pump = Promise.promisify(require('pump'));
const fs = Promise.promisifyAll(require('graceful-fs'), {
@@ -50,7 +49,7 @@ const verifyAsset = async (url, savePath, onProgress) => {
},
});

if (!hasOwnProp(headers, Symbol.keyFor(SIGNATURE_HEADER))) {
if (!headers[Symbol.keyFor(SIGNATURE_HEADER)]) {
throw new Error('Signature header not found');
}

@@ -104,7 +104,6 @@
"get-port": "^4.0.0",
"got": "^9.5.0",
"graceful-fs": "^4.1.15",
"has-own-prop": "^1.0.1",
"helmet": "^3.15.0",
"http-proxy": "^1.17.0",
"jsonwebtoken": "^8.4.0",
@@ -163,7 +162,7 @@
"downloadjs": "^1.4.7",
"electron-forge": "^5.2.3",
"electron-installer-dmg": "^2.0.0",
"electron-packager": "^12.2.0",
"electron-packager": "~12.2.0",
"electron-prebuilt-compile": "3.0.13",
"ember-ajax": "^4.0.1",
"ember-auto-import": "^1.2.19",
@@ -272,7 +271,7 @@
"resolutions": {
"electron-forge": "^5.2.3",
"electron-installer-dmg": "^2.0.0",
"electron-packager": "^12.2.0"
"electron-packager": "~12.2.0"
},
"engines": {
"node": ">= 10.2.0"
@@ -6914,7 +6914,7 @@ electron-osx-sign@^0.4.1:
minimist "^1.2.0"
plist "^3.0.1"

electron-packager@^11.0.0, electron-packager@^12.2.0:
electron-packager@^11.0.0, electron-packager@~12.2.0:
version "12.2.0"
resolved "https://registry.yarnpkg.com/electron-packager/-/electron-packager-12.2.0.tgz#e38e0702a12e5f62a00a03aabd0b9ad28aebab4b"
integrity sha512-T5W/FIK4VXhYIOWxkehmz6zXt2S/sA9JZ3AL+/jeKCicQY6QVQ0K8B7W801L+GPTwbgTPycHjO+iqEf1BhZ+Iw==
@@ -10881,11 +10881,6 @@ has-flag@^3.0.0:
resolved "https://registry.yarnpkg.com/has-flag/-/has-flag-3.0.0.tgz#b5d454dc2199ae225699f3467e5a07f3b955bafd"
integrity sha1-tdRU3CGZriJWmfNGfloH87lVuv0=

has-own-prop@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/has-own-prop/-/has-own-prop-1.0.1.tgz#4a5c1326a45146b836cadd4b79039b9e9476a4f9"
integrity sha512-ZYvbzPe2HdCr1vWrmjZPajdPPfitAqctTZl4KW/UTmJv4S2An40pApQGT5c4NUaC3Nlc+lM+RJDLWu+Jed/hRw==

has-symbols@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/has-symbols/-/has-symbols-1.0.0.tgz#ba1a8f1af2a0fc39650f5c850367704122063b44"

0 comments on commit 0db3380

Please sign in to comment.
You can’t perform that action at this time.