New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML metadata parsing filename issue #1022

Closed
fmariluis opened this Issue Dec 18, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@fmariluis

fmariluis commented Dec 18, 2016

If a binary file has a somewhat 'complex' filename, nanoc cannot match the binary file with the metadata.

Steps to reproduce

Given a binary file with a filename like ubuntu-16.10-server-amd64.iso.torrent, I would like to create a yaml file with some metadata. According to the docs, a yaml file like ubuntu-16.10-server-amd64.iso.yaml should work.

However, the only way this works is if I change the binary filename to: ubuntu-16-10-server-amd64.iso.torrent (note that I replaced the dot in 16.10 with a dash) and therefore, the yaml file to ubuntu-16-10-server-amd64.iso.yaml.

I know that parsing filenames can be complex (specially considering multiplatform projects), so if there's no way around this, docs should be updated with this case (I can do this 😉).

Otherwise, thanks for an amazing project!

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Jan 11, 2017

Member

I have a fix in #1059.

Member

ddfreyne commented Jan 11, 2017

I have a fix in #1059.

@ddfreyne ddfreyne closed this in #1059 Jan 11, 2017

ddfreyne added a commit that referenced this issue Jan 11, 2017

Merge pull request #1059 from nanoc/gh-1022
Allow periods in identifiers for full identifiers

@ddfreyne ddfreyne added this to the 4.5.2 milestone Jan 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment