Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No URL encoding in sitemaps #1052

Closed
anton-tsyganenko opened this issue Jan 6, 2017 · 0 comments
Closed

No URL encoding in sitemaps #1052

anton-tsyganenko opened this issue Jan 6, 2017 · 0 comments
Labels
Milestone

Comments

@anton-tsyganenko
Copy link

@anton-tsyganenko anton-tsyganenko commented Jan 6, 2017

Nanoc SitemapXML helper doesn't encode URLs that contain non-ascii-characters, but that is required.
https://support.google.com/webmasters/answer/183668
For example, if I create create a file called проверка.html, the sitemap looks like this:

 <url>
    <loc>https://example.com/проверка/</loc>
    <lastmod>2017-01-06</lastmod>
  </url>

But it has to look like this:

 <url>
    <loc>https://example.com/%D0%BF%D1%80%D0%BE%D0%B2%D0%B5%D1%80%D0%BA%D0%B0/</loc>
    <lastmod>2017-01-06</lastmod>
  </url>
ddfreyne added a commit that referenced this issue Jan 9, 2017
ddfreyne added a commit that referenced this issue Jan 9, 2017
ddfreyne added a commit that referenced this issue Jan 10, 2017
ddfreyne added a commit that referenced this issue Jan 11, 2017
ddfreyne added a commit that referenced this issue Jan 11, 2017
Escape URLs in sitemaps (fixes #1052)
@ddfreyne ddfreyne added this to the 4.5.2 milestone Jan 11, 2017
ddfreyne added a commit that referenced this issue Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.