Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Nokogiri dependency? #1053

Closed
DieterDePaepe opened this issue Jan 9, 2017 · 3 comments
Closed

Missing Nokogiri dependency? #1053

DieterDePaepe opened this issue Jan 9, 2017 · 3 comments
Milestone

Comments

@DieterDePaepe
Copy link

@DieterDePaepe DieterDePaepe commented Jan 9, 2017

On a fresh (windows) installation, nanoc fails to start due to a failure to load Nokogiri.

Steps to reproduce

Follow steps decribed on https://nanoc.ws/doc/installation/
On commandline: nanoc help

Expected behavior

A help printout.

Actual behavior

A stack trace - see below

Details

OS: Windows 7
Ruby: ruby 2.2.6p396 (2016-11-15 revision 56800) [i386-mingw32]
Nanoc:

Nanoc 4.5.0 (c) 2007-2017 Denis Defreyne.
Running ruby 2.2.6 (2016-11-15) on i386-mingw32 with RubyGems 2.4.5.2.

Resolved after doing gem install nokogiri.

Crash log

Gist

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Jan 9, 2017

This is indeed wrong. The problem is not a missing nokogiri dependency, but rather that Nokogiri should be required when needed, rather than eagerly. Fix coming up.

@ddfreyne ddfreyne added this to the 4.5.1 milestone Jan 9, 2017
@ddfreyne ddfreyne closed this in 15b7c4c Jan 9, 2017
@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Jan 9, 2017

This bug is sadly tricky to test for automatically.

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Jan 9, 2017

Fixed in Nanoc 4.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants