Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store temp data per output directory #1070

Closed
ddfreyne opened this Issue Jan 16, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@ddfreyne
Copy link
Member

ddfreyne commented Jan 16, 2017

See #1069 (comment).

The temporary data ideally needs to be stored per output directory, rather than per environment.

The current approach (storing only one set of temporary data) is correct, but yields sub-optimal performance.

@Fjan

This comment has been minimized.

Copy link
Contributor

Fjan commented Jan 16, 2017

As mentioned in the comment on #1069, avoiding recompilation can probably only be achieved if the output directories for each environment are completely separate (not the same and not in each others hierarchy). This is probably true for most use cases.

The simplest implementation is probably to invalidate the tmp directory for users that have at least one duplicate output directory, and then restore a8e1160

@ddfreyne

This comment has been minimized.

Copy link
Member Author

ddfreyne commented Jan 17, 2017

@Fjan A fix is in #1071. There’s no explicit invalidation going on, as it’s not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.