New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation fails when cache directory exists (sometimes) #1094

Closed
agross opened this Issue Mar 2, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@agross
Contributor

agross commented Mar 2, 2017

Nanoc compilation sometimes fails unless you rm -rf tmp.

Expected behavior

Compilation succeeds.

Actual behavior

Compilation fails.

Details

The item reported in the log below is passed-through, no filters and such. Note the path pointing to a temporary file.

Crash log

https://gist.github.com/agross/9831ab6eb3844783424b19f64bd7831c

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Mar 3, 2017

Member

I’m unsure how to reproduce this. Can you try whether the issue also exists on master, and if so, could you provide a reproduction (a small one is preferred, but not required).

Member

ddfreyne commented Mar 3, 2017

I’m unsure how to reproduce this. Can you try whether the issue also exists on master, and if so, could you provide a reproduction (a small one is preferred, but not required).

@agross

This comment has been minimized.

Show comment
Hide comment
@agross

agross Mar 3, 2017

Contributor

I'll try to. I think I can reproduce it locally pretty reliably, but the project is rather complex.

Contributor

agross commented Mar 3, 2017

I'll try to. I think I can reproduce it locally pretty reliably, but the project is rather complex.

@sunshineco

This comment has been minimized.

Show comment
Hide comment
@sunshineco

sunshineco Mar 4, 2017

Contributor

This failure looks remarkably similar to the failure mentioned tangentially in #1082. I came up with a reproduction recipe, but it only manifested when some in-progress patches from Denis were applied. However, if the underlying cause is the same, perhaps those patches and the recipe I provided could help track down the problem (assuming it still manifests on master).

Contributor

sunshineco commented Mar 4, 2017

This failure looks remarkably similar to the failure mentioned tangentially in #1082. I came up with a reproduction recipe, but it only manifested when some in-progress patches from Denis were applied. However, if the underlying cause is the same, perhaps those patches and the recipe I provided could help track down the problem (assuming it still manifests on master).

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Mar 4, 2017

Member

Any reproductions that work with master would be incredibly valuable!

I know that @gpakosz is also experiencing this issue.

Member

ddfreyne commented Mar 4, 2017

Any reproductions that work with master would be incredibly valuable!

I know that @gpakosz is also experiencing this issue.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Mar 5, 2017

Member

I have a reproduction case!

Member

ddfreyne commented Mar 5, 2017

I have a reproduction case!

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Mar 5, 2017

Member

A (WIP) fix is in #1109.

Member

ddfreyne commented Mar 5, 2017

A (WIP) fix is in #1109.

@ddfreyne ddfreyne modified the milestone: 4.6.3 Mar 5, 2017

@ddfreyne ddfreyne closed this in #1109 Mar 5, 2017

ddfreyne added a commit that referenced this issue Mar 5, 2017

Merge pull request #1109 from nanoc/gh-1094
Do not reuse cached binary content
@agross

This comment has been minimized.

Show comment
Hide comment
@agross

agross Mar 5, 2017

Contributor

Works for me! Many thanks!

Contributor

agross commented Mar 5, 2017

Works for me! Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment