New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse error when using four dashes to signal metadata #1222

Closed
denis-soundcloud opened this Issue Sep 28, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@denis-soundcloud

denis-soundcloud commented Sep 28, 2017

Using four dashes to indicate a metadata section leads to a confusing error.

Expected

A clear error when using four dashes, stating that four dashes are not valid.

Actual

A weird error:

did not find expected node content while parsing a block node at line 2 column 1

Details

The filesystem data source sometimes accepts 3, 4, or 5 dashes, and at other times, accepts only 3 or 5:

It should disallow four dashes.

@ddfreyne ddfreyne closed this in #1223 Sep 29, 2017

ddfreyne added a commit that referenced this issue Sep 29, 2017

Merge pull request #1223 from nanoc/gh-1222-four-dashes
Properly handle four dashes for separating metadata
@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Sep 29, 2017

Member

CC @BenjaminDebeerst — this’ll be fixed in the 4.8.10 release.

Member

ddfreyne commented Sep 29, 2017

CC @BenjaminDebeerst — this’ll be fixed in the 4.8.10 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment