Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The erubi filter does not show the location for compilation errors #1255

Closed
Fjan opened this issue Nov 28, 2017 · 1 comment
Closed

The erubi filter does not show the location for compilation errors #1255

Fjan opened this issue Nov 28, 2017 · 1 comment

Comments

@Fjan
Copy link
Contributor

@Fjan Fjan commented Nov 28, 2017

Steps to reproduce

  1. Create an erb file that parses initially but with an error that will only happen during compilation
    <%= 'test' # this will parse but breaks at execution time %>
  2. put filter :erubi in the Rules file
  3. nanoc compile
  4. the crash output will not show the location of the offending file

Expected behavior

The crash log should show the item being compiled

Actual behavior

The crash log shows an incorrect line

Details

This is trivial to fix, the eval is missing the filename parameter, I will submit a PR shortly.

ddfreyne added a commit that referenced this issue Dec 2, 2017
Add filename to erubi exceptions
@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Dec 2, 2017

This is fixed in Nanoc 4.8.15 (just released).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants