Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#find_all does not behave like Enumerable#find_all #1284

ddfreyne opened this issue Dec 27, 2017 · 0 comments

#find_all does not behave like Enumerable#find_all #1284

ddfreyne opened this issue Dec 27, 2017 · 0 comments


Copy link

@ddfreyne ddfreyne commented Dec 27, 2017

IdentifiableCollection#find_all takes one argument, while Enumerable#find_all takes a block.

This is confusing, because even though IdentifiableCollection is Enumerable, not all of Enumerable’s methods behave as expected.

Suggestion: allow IdentifiableCollection#find_all to also be called with a block and no arguments, which would make it behave like Enumerable#find_all.

@ddfreyne ddfreyne closed this in 1448106 Dec 28, 2017
ddfreyne added a commit that referenced this issue Dec 28, 2017
Let #find_all take a block (fixes #1284)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant