Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Failure in external_links check #1294
Steps to reproduce
I expected to see some warnings about broken external links.
Nanoc dies with a
I have just added a lot of older content to the site. It's possible that some of the old content has links to unresponsive, very slow or disappeared sites.
Oh, that's really useful.
Bad news and worse news, I'm afraid.
It seems as if this problem is intermittent. I ran my test a few times this morning with the original configuration, and it worked (reporting bad links).
Switching to the new configuration, my first run was a failure with the same
Finally, I'm also seeing this warning message, which I think is new:
This is on the latest macOS, with ruby 2.4.3p205 (2017-12-14 revision 61247) [x86_64-darwin17] installed using MacPorts.
My current working theory is:
It's hard to see where an exception would come from in external link validation. The most obvious case would be timeouts, but that seems to be handled inside the
Another would be if a redirect goes to something that isn't a valid URI: the
A third thing I noticed was that if I added a lot of
For now, I have added some diagnostics to two locations:
So far, I haven't had the issue recur but I will keep this stuff live until I do, and hopefully we will see an exception being raised that we aren't expecting.
Here, I'm referring to the call in
@iay Can you give the branch I mentioned another try?
This won’t fix the problem yet, but my hope is that this will reveal the underling error that is causing the problem.
added a commit
Jan 21, 2018
I have updated to that and run
I don't know that proves anything, as the problem was intermittent anyway, but it's hopeful.
I suggest just closing this issue now; I can reopen it if the problem comes back.