New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal_links check for xhtml files #1328

Closed
lo48576 opened this Issue Mar 4, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@lo48576

lo48576 commented Mar 4, 2018

internal_links checker checks *.html files, but not *.xhtml files.

Steps to reproduce

  1. Prepare (generate) *.xhtml files with wrong site-local links.
  2. Run nanoc check ilinks

Expected behavior

nanoc check ilinks detects broken links in *.xhtml files.

Actual behavior

nanoc check ilinks doesn't detect broken links in *.xhtml files.

Details

Maybe this line should be changed:

filenames = output_filenames.select { |f| File.extname(f) == '.html' }

I'm not sure this should be configurable or can be hard-coded, but I think not only *.html but also *.xhtml and *.htm should be (can be) checked as HTML file.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Mar 4, 2018

Member

Good catch! Here’s a fix: #1329

Member

ddfreyne commented Mar 4, 2018

Good catch! Here’s a fix: #1329

@ddfreyne ddfreyne closed this in #1329 Mar 4, 2018

ddfreyne added a commit that referenced this issue Mar 4, 2018

Merge pull request #1329 from nanoc/gh-1328-broken-links-in-xhtml-and…
…-htm

Also consider .xhtml and .html in checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment