New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies on binary items are not triggered #1358

Closed
ddfreyne opened this Issue Sep 18, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@ddfreyne
Member

ddfreyne commented Sep 18, 2018

When the content of a binary item changes, items that depend on this binary item are not recompiled.

Steps to reproduce

  1. Create a binary item A
  2. Create an item B that depends on this binary item
  3. Compile
  4. Change contents of item A
  5. Compile

Expected behavior

Item B is recompiled (identical or updated is shown)

Actual behavior

Item B is not recompiled.

Details

The filesystem data source’s #content_checksum_data_for defaults to '' for the content. It should return nil instead, so that the checksum is calculated properly.

CC @moll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment