Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanoc v4.10.1 doesn't seem to recompile when layout Haml options changed #1372

Closed
moll opened this issue Oct 19, 2018 · 4 comments
Closed

Nanoc v4.10.1 doesn't seem to recompile when layout Haml options changed #1372

moll opened this issue Oct 19, 2018 · 4 comments

Comments

@moll
Copy link

@moll moll commented Oct 19, 2018

Hey,

I'm not sure if it's by design or not, but I was playing around with Haml's remove_whitespace option and changing it (adding/removing, for example) in the layout rule doesn't seem to trigger any recompilations. Nuking the output directory does show changes however.

layout "/**/*", :haml, remove_whitespace: true
@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Oct 21, 2018

I can confirm that this happens — and it’s not expected. Will work on a fix.

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Oct 21, 2018

There is a fix in #1373, which I’ve tested with your site.

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Oct 21, 2018

This is now released in Nanoc 4.10.2.

@moll
Copy link
Author

@moll moll commented Jun 23, 2019

A belated thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants