Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link validation fails for links to Google Code Issues. #279

Closed
richardkmichael opened this issue Mar 11, 2013 · 6 comments
Closed

Link validation fails for links to Google Code Issues. #279

richardkmichael opened this issue Mar 11, 2013 · 6 comments

Comments

@richardkmichael
Copy link

@richardkmichael richardkmichael commented Mar 11, 2013

Nanoc reports 404 for: http://code.google.com/p/rubyenterpriseedition/issues/detail?id=59, when curl and Net/HTTP report 200. See: https://gist.github.com/ddfreyne/5136703

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Mar 11, 2013

This happens because the query is not taken into account here. Will fix.

@envygeeks
Copy link

@envygeeks envygeeks commented Mar 24, 2013

@ddfreyne has this been pushed up into stable yet?

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Mar 24, 2013

@envygeeks No, and it hasn’t been fixed yet. It’ll be part of 3.6.3.

@envygeeks
Copy link

@envygeeks envygeeks commented Mar 26, 2013

@ddfreyne We've rewrote the external_links checker if you would like to just merge what we did, it uses typhoeus now with a backoff time on failures: https://github.com/rvm/rvm-site/blob/master/lib/external_links.rb

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Mar 31, 2013

@envygeeks Ahh, this is pretty cool! I might steal this code. It doesn’t seem to handle redirects properly though (301, 302).

Edit: Nevermind; I looked over the followlocation: true. Still, I don’t think 301 and 302 should be considered a success.

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Apr 1, 2013

I’ve opted to fix the current implementation instead of rewriting it with typhoeus. Maybe something that’ll land in nanoc 3.7 or 4.0 though!

@bobthecow bobthecow closed this Apr 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants