Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout nil during Filter processing #346

Closed
raphinesse opened this issue Nov 3, 2013 · 4 comments
Closed

Layout nil during Filter processing #346

raphinesse opened this issue Nov 3, 2013 · 4 comments

Comments

@raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Nov 3, 2013

Filters crash when trying to access assigns[:layout].attributes since assigns[:layout] seems to be nil whether item is laid out or not.

I noticed this while using Nanoc::Filters::Handlebars but I can't tell whether the access should not happen or assigns[:layout] should not be nil.

I'm happy to provide further details about my setup if necessary. Using 3.6.5 currently.

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Nov 3, 2013

Can you share your crash.log and your Rules files (preferrably on gist)?

@raphinesse
Copy link
Contributor Author

@raphinesse raphinesse commented Nov 3, 2013

Here you go: https://gist.github.com/raphinesse/ea8de76518178bc03172

The only change I made to the default site template was replacing the ERB filtering step with Handlebars filtering.

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Nov 3, 2013

That’s indeed a bug. Will fix.

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Nov 10, 2013

Fixed in PR #348.

@ddfreyne ddfreyne closed this Nov 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants