Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanoc --create-site creates a default layout that references style.css when it should be stylesheet.css #410

Closed
jf opened this issue Mar 31, 2014 · 6 comments

Comments

@jf
Copy link

@jf jf commented Mar 31, 2014

hi, so as per subject. Not too sure why this hasnt been noticed before, but it's there:

https://github.com/nanoc/nanoc/blob/master/lib/nanoc/cli/commands/create-site.rb#L270 (default layout uses style.css)

https://github.com/nanoc/nanoc/blob/master/lib/nanoc/cli/commands/create-site.rb#L381 (but DEFAULT_STYLESHEET is created as stylesheet.css)

@bobthecow
Copy link
Member

@bobthecow bobthecow commented Mar 31, 2014

Nobody noticed because, until the latest release, create-site also created a custom routing rule for the stylesheet:

https://github.com/nanoc/nanoc/blob/3.6.7/lib/nanoc/cli/commands/create-site.rb#L118-L120

Good catch. We'll get that taken care of.

@jf
Copy link
Author

@jf jf commented Mar 31, 2014

I see. Thanks for the explanation! I hope the fix will be to just fix the layout reference instead of putting that rule back in?

@bobthecow
Copy link
Member

@bobthecow bobthecow commented Mar 31, 2014

that would be my guess.

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Mar 31, 2014

Yep, the /style.css should be /stylesheet.css (or, perhaps even better, @items['/stylesheet/'].path).

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Mar 31, 2014

#411 is a potential fix.

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Mar 31, 2014

Fixed by #411. Thanks for reporting!

@ddfreyne ddfreyne closed this Mar 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants