Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to rubyforge.org have to be replaced #454

Closed
grv87 opened this issue Jun 22, 2014 · 4 comments
Closed

Links to rubyforge.org have to be replaced #454

grv87 opened this issue Jun 22, 2014 · 4 comments
Milestone

Comments

@grv87
Copy link

@grv87 grv87 commented Jun 22, 2014

Links to rubyforge.org (e.g. in comments describing filters) point to emptiness and have to be replaced.

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Jun 22, 2014

Good point, thanks for spotting.

Does that look right?

I knew about Rubyforge closing down, but I never thought I’d still have so many links. I guess I should run nanoc check elinks more often :)

@grv87
Copy link
Author

@grv87 grv87 commented Jun 24, 2014

I believe that these links are correct except that (copy-paste error):

And link for Curb should not be removed.

BTW, how exactly nanoc check elinks works? For example, DNS name maruku.rubyforge.org is still resolvable, but the server doesn't respond on HTTP(S). I wonder whether nanoc could determine such problem.

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Jun 25, 2014

@grv87 nanoc check elinks works by making HTTP requests and asserting that the response code is 200.

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Aug 9, 2014

Fixed by #467.

@ddfreyne ddfreyne closed this Aug 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants