Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort order not preserved in Atom feed #533

Closed
ddfreyne opened this issue Feb 20, 2015 · 3 comments
Closed

Sort order not preserved in Atom feed #533

ddfreyne opened this issue Feb 20, 2015 · 3 comments
Milestone

Comments

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Feb 20, 2015

The Atom feed helper always sorts by created_at. There is no way to change the sort order.

This is a bug, since it was previously possible to pass in an array and not have it sorted.

I propose a preserve_order option, defaulting to false (in order to stay backwards compatible with current behavior).

Also see #532.

@bobthecow
Copy link
Member

@bobthecow bobthecow commented Feb 20, 2015

👍

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Feb 21, 2015

Potential fix in #534.

@th-h
Copy link
Contributor

@th-h th-h commented Feb 22, 2015

Yeah, I should have opened an issue before. Sorry.

My train of thought was, as the current behaviour (as of 3.7.5) already was a backwards compatibility break (introduced by a9c9478 in 2012), I could just fix it without adding another option (as the default behaviour without setting the :article option wouldn't change and everybody setting :article could just be sorted any way one likes).

I didn't bear in mind that I'd yet again break backwards compatibility.

The fix in #534 works for me. Thank you!

@ddfreyne ddfreyne closed this Feb 22, 2015
@ddfreyne ddfreyne added this to the 3.7.6 milestone Apr 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants