Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing #rep_named in view API #586

Closed
ddfreyne opened this issue May 16, 2015 · 0 comments
Closed

Missing #rep_named in view API #586

ddfreyne opened this issue May 16, 2015 · 0 comments

Comments

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented May 16, 2015

The following no longer works, because #rep_named is missing:

@item.rep_named(:foo).path

This is not so useful considering it is mostly useful for accessing paths and compiled content, which is possible with @item.path and @item.compiled_content anyway.

It seems “correct” to expose #rep_named because @item_rep is exposed too. Perhaps not as #rep_named, but rather an name-addressable reps array:

@item.reps[:foo].path
@ddfreyne ddfreyne added this to the 4.0.0 milestone Jun 20, 2015
@ddfreyne ddfreyne added this to the 4.0.0 milestone Jun 20, 2015
@ddfreyne ddfreyne removed this from the 4.0.0 milestone Jun 20, 2015
@ddfreyne ddfreyne removed this from the 4.0.0 milestone Jun 20, 2015
@ddfreyne ddfreyne added this to the 4.0.0 milestone Jun 20, 2015
@ddfreyne ddfreyne added this to the 4.0.0 milestone Jun 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant