Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default.html from create_site easily crashes on compile #685

Closed
bburton opened this Issue Jul 25, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@bburton
Copy link

bburton commented Jul 25, 2015

After running the nanoc create_site command, the resulting default.html layout will crash on compile if the /stylesheet.css file is moved or renamed:

Message:

NoMethodError: undefined method `path' for nil:NilClass

Compilation stack:

  - [item]   /index.html (rep default)

This is going to cause consternation for a lot of users as almost everyone who creates a new site is going to move or rename stylesheet.css and may not fix the reference in default.html at the same time.

It's really much better to leave the stylesheet.css link hard coded in default.html the way it was since users will quickly figure out they're getting unstyled content and fix the reference.

See https://github.com/nanoc/nanoc/blob/master/lib/nanoc/cli/commands/create-site.rb#L257

@ddfreyne

This comment has been minimized.

Copy link
Member

ddfreyne commented Jul 25, 2015

Same as #684 I believe.

@ddfreyne ddfreyne added this to the 4.0.0 milestone Jul 25, 2015

@ddfreyne

This comment has been minimized.

Copy link
Member

ddfreyne commented Sep 18, 2015

Makes sense. Combined with an internal_links deploy-time check, the chance of ever deploying a site that is not properly styled is very low.

@ddfreyne

This comment has been minimized.

Copy link
Member

ddfreyne commented Sep 19, 2015

Fixed by #701.

@ddfreyne ddfreyne closed this Sep 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.