New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#with_ext is confusing #697

Closed
ddfreyne opened this Issue Aug 17, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@ddfreyne
Member

ddfreyne commented Aug 17, 2015

This method is confusing, since it deletes a single extension (leaving others) and adding the given one.

It also does not allow chaining; for instance, foo.without_exts.with_ext('html') will not work.

Perhaps #with_ext should be removed completely, possibly replaced by #replace_ext and #replace_exts.

See also: #664, #679, #696.

@barraq

This comment has been minimized.

Show comment
Hide comment
@barraq

barraq Sep 18, 2015

Contributor

👍

Contributor

barraq commented Sep 18, 2015

👍

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Sep 18, 2015

Member

Fixed in #700 by removing #with_ext.

I figured #replace_ext and/or #replace_exts is not very useful considering #+ already exists. If it turns out to be a nice-to-have, it might arrive in 4.1.

Member

ddfreyne commented Sep 18, 2015

Fixed in #700 by removing #with_ext.

I figured #replace_ext and/or #replace_exts is not very useful considering #+ already exists. If it turns out to be a nice-to-have, it might arrive in 4.1.

@ddfreyne ddfreyne closed this Sep 18, 2015

lifepillar pushed a commit to lifepillar/nanoc4-template that referenced this issue Sep 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment