Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when comparing item reps #735

Closed
ddfreyne opened this issue Nov 26, 2015 · 1 comment
Closed

Crash when comparing item reps #735

ddfreyne opened this issue Nov 26, 2015 · 1 comment
Milestone

Comments

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Nov 26, 2015

Comparing an item rep with anything else is always going to crash, because the #== method doesn’t check whether the compared thing is also an item rep:

def ==(other)
  item.identifier == other.item.identifier && name == other.name
end
@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Nov 28, 2015

Fixed in #738.

@ddfreyne ddfreyne closed this Nov 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant