New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove environment variables from crash.log? #798

Closed
gjtorikian opened this Issue Jan 12, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@gjtorikian
Member

gjtorikian commented Jan 12, 2016

Howdy! I just noticed that the crash.log dump file spits out a user's entire environment. I'm concerned that, in the event that a user has sensitive information (GitHub tokens, AWS tokens, etc), these variables will be leaked.

Poking around at random issues in this repo, I see a few places where people just straight up paste the log: #199, #405.

Would it be possible to just omit this information?

/cc @mastahyeti

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Jan 13, 2016

Member

Yup, totally makes sense. Having the environment available in crash.log wasn’t as useful as I imagined in the first place, and when it’s necessary, we can still get hold of it by other means.

PR: #800

Member

ddfreyne commented Jan 13, 2016

Yup, totally makes sense. Having the environment available in crash.log wasn’t as useful as I imagined in the first place, and when it’s necessary, we can still get hold of it by other means.

PR: #800

@ddfreyne ddfreyne added this to the 4.1.2 milestone Jan 13, 2016

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Jan 13, 2016

Member

Fixed in #800. This’ll be part of the 4.1.2 release.

Member

ddfreyne commented Jan 13, 2016

Fixed in #800. This’ll be part of the 4.1.2 release.

@ddfreyne ddfreyne closed this Jan 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment