New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessor not executed before check #841

Closed
francois2metz opened this Issue Mar 24, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@francois2metz

francois2metz commented Mar 24, 2016

The fix in #784 have been removed in #788.

Dynamic items created in the preprocess block are marked as stale.

To fix it, I added site.compiler.action_provider.preprocess(site) in lib/nanoc/cli/commands/check.rb.

I can open a pull request if you think it is the right fix.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Mar 24, 2016

Member

You’re right—#788 should’ve kept the preprocessing step before checks.

Your suggestion seems correct. I’ll implement the fix and add a regression spec.

Member

ddfreyne commented Mar 24, 2016

You’re right—#788 should’ve kept the preprocessing step before checks.

Your suggestion seems correct. I’ll implement the fix and add a regression spec.

@ddfreyne ddfreyne added this to the 4.1.5 milestone Mar 24, 2016

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Mar 24, 2016

Member

Fix in #842.

Member

ddfreyne commented Mar 24, 2016

Fix in #842.

@ddfreyne ddfreyne closed this Mar 24, 2016

@francois2metz

This comment has been minimized.

Show comment
Hide comment
@francois2metz

francois2metz commented Mar 24, 2016

Thanks!

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Mar 24, 2016

Member

This is released in 4.1.5 now.

Member

ddfreyne commented Mar 24, 2016

This is released in 4.1.5 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment