New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency of generated item to its layout never unmet #891

Closed
GeekyUX opened this Issue Jul 2, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@ghost

ghost commented Jul 2, 2016

Encountered in Nanoc 4.2.1

Steps to reproduce:

  1. Create a new site

  2. Add the preprocess rule:

    preprocess do
      items.create('', {}, '/hello.html')
    end
  3. Compile; This creates output/index.html and output/hello/index.html

  4. Modify layouts/default.html in some way (I've been adding exclamation marks to <title>)

  5. Recompile

Expected outcome: Both output/index.html and output/hello/index.html should be updated.
Actual outcome: Only output/index.html is updated.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 2, 2016

Note: I believe this is related to issue #885

ghost commented Jul 2, 2016

Note: I believe this is related to issue #885

@ddfreyne ddfreyne added this to the 4.2.2 milestone Jul 2, 2016

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Jul 2, 2016

Member

Oh yikes—definitely a bug.

Member

ddfreyne commented Jul 2, 2016

Oh yikes—definitely a bug.

ddfreyne added a commit that referenced this issue Jul 2, 2016

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Jul 2, 2016

Member

Fix is in #893.

Member

ddfreyne commented Jul 2, 2016

Fix is in #893.

@ddfreyne ddfreyne closed this Jul 2, 2016

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 5, 2016

Thanks, Denis! That was quick! 👍

ghost commented Jul 5, 2016

Thanks, Denis! That was quick! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment