Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compiler stack #1000

Merged
merged 6 commits into from Nov 24, 2016

Conversation

Projects
None yet
1 participant
@ddfreyne
Copy link
Member

commented Nov 23, 2016

Remove the compiler stack and print the details of the current in-compilation item rep.

Detailed description

This is done in two steps:

  1. Wrap every error raised during compilation in an error decorator that will contain the current item rep that is being compiled, and ensure that item rep is printed in the error handler.

  2. Remove the now unused compiler stack.

Before:

before

After:

after

To do

  • Tests
  • Cleanup
    • Rename WithItemRepError to CompilerError
    • Unwrap consistently; don’t check respond_to?

@ddfreyne ddfreyne force-pushed the wrap-item-rep-in-error branch 5 times, most recently from 84e2cdb to 460500a Nov 23, 2016

@ddfreyne ddfreyne force-pushed the wrap-item-rep-in-error branch from 12fe074 to 3036e92 Nov 24, 2016

@ddfreyne ddfreyne force-pushed the wrap-item-rep-in-error branch from bbd485c to ffce22c Nov 24, 2016

@ddfreyne ddfreyne merged commit 501b52c into master Nov 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the wrap-item-rep-in-error branch Nov 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.