Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate outdatedness only across compiled-content deps #1024

Merged
merged 1 commit into from Dec 19, 2016

Conversation

Projects
None yet
1 participant
@ddfreyne
Copy link
Member

ddfreyne commented Dec 19, 2016

This prevents transitive dependencies from needlessly generating outdatedness. Transitive dependencies should only be considered if they apply to compiled content.

Scenario 1

Given:

  • Item A has an attribute dependency on item B
  • Item B has an attribute dependency on item C

When:

  • Item C’s attributes change

Then:

  • Item B is outdated
  • Item A is not outdated

Scenario 2

Given:

  • Item A has a compiled content dependency on item B
  • Item B has an attribute dependency on item C

When:

  • Item C’s attributes change

Then:

  • Item B is outdated
  • Item A is outdated

@ddfreyne ddfreyne added this to the 4.4.4 milestone Dec 19, 2016

@ddfreyne ddfreyne merged commit 75e8ed3 into master Dec 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the transitive-deps-outdatedness branch Dec 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.