Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only treat :last snapshot as movable #1041

Merged
merged 6 commits into from Dec 25, 2016
Merged

Only treat :last snapshot as movable #1041

merged 6 commits into from Dec 25, 2016

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Dec 25, 2016

The :pre, :post and :last snapshots have typically been marked as “movable”, which means that in order to access content at those snapshots, certain requirements have to be met. The logic around this is confusing, and so this PR simplifies this.

  • The only snapshot that is “movable” is the :last snapshot.

  • To access compiled content of a snapshot, the snapshot content needs to exist, or, for :last, the item rep needs to have been fully compiled.

  • The executor no longer creates snapshots in #filter and #layout. The recording executor (or generally speaking, the rule DSL) takes care of generating the appropriate snapshots.

  • Snapshot defs and snapshot actions cannot be non-final.

Fixes #1040.

@ddfreyne ddfreyne force-pushed the fix-moving-pre-snapshots branch from 4c615e5 to ef5cfd0 Dec 25, 2016
@ddfreyne ddfreyne force-pushed the fix-moving-pre-snapshots branch from 95971f7 to 55b8f52 Dec 25, 2016
@ddfreyne ddfreyne merged commit 6ae09f8 into master Dec 25, 2016
1 check passed
Loading
@ddfreyne ddfreyne deleted the fix-moving-pre-snapshots branch Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant