Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume compilation after exception #1044

Merged
merged 7 commits into from Dec 31, 2016

Conversation

Projects
None yet
1 participant
@ddfreyne
Copy link
Member

commented Dec 30, 2016

Support incremental compilation by allowing compilation to resume after an exception

Detailed description

Before:

  1. Load checksums, dependencies, …
  2. Determine outdatedness
  3. Compile all items
  4. Write new checksums, dependencies, …

After:

  1. Load checksums, dependencies, …
  2. Determine outdatedness
  3. Remember all currently outdated items in a new outdatedness store
  4. Write new checksums, dependencies, …
  5. Compile all items; after each item, compilation mark the compiled item as no longer outdated
  6. Write new outdatedness store

The outdatedness checker will not be integrated with the outdatedness store.

To do

  • Do not store non-existant items in OutdatednessStore
  • Create OutdatednessStore in CompilerLoader

Issues

  • The OutdatednessStore is stored twice. This isn’t really a problem, but there’s no clear/clean way to fix that right now.

@ddfreyne ddfreyne force-pushed the outdatedness-store branch from 3a08a2b to 1f44181 Dec 31, 2016

@ddfreyne ddfreyne force-pushed the outdatedness-store branch 3 times, most recently from 256d337 to 226e291 Dec 31, 2016

@ddfreyne ddfreyne force-pushed the outdatedness-store branch from deccc2c to 5c9f263 Dec 31, 2016

@ddfreyne ddfreyne merged commit 3b0c77f into master Dec 31, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the outdatedness-store branch Dec 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.