Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store temp data per-env #1069

Merged
merged 1 commit into from Jan 16, 2017

Conversation

Projects
None yet
2 participants
@ddfreyne
Copy link
Member

commented Jan 16, 2017

Fixes #1067.

Do not store temp data per-env
This trips up the dependency tracker and outdatedness checker and can
cause wrong compilation output.

@ddfreyne ddfreyne added this to the 4.5.4 milestone Jan 16, 2017

@ddfreyne ddfreyne merged commit a8e1160 into master Jan 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the gh-1067 branch Jan 16, 2017

@Fjan

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2017

This commit has the side effect of doing a full recompile each time the environment changes! In a normal workflow where you fix a typo on staging and then on production you now have to wait for two full recompiles... This makes working with large nanoc sites unbearably slow, can we please revert?

@Fjan

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2017

A better solution to prevent issue #1067 would be to do a full recompile only if the output directories for the environments are the same. In normal use you would use two different output directories so the issue would not occur.

@ddfreyne

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2017

@Fjan I’ve created a separate issue for this (#1070). This PR can’t be reverted as-is, as it reintroduces a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.