New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require compilation before calling #binary? #1083

Merged
merged 1 commit into from Feb 16, 2017

Conversation

Projects
None yet
1 participant
@ddfreyne
Member

ddfreyne commented Feb 8, 2017

Fixes part of #1082.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Feb 16, 2017

Member

I’ll merge this PR, as it is a step in the right direction. A proper fix, which involves being able to check the binary-ness of an item rep without needing it to be compiled first, is still pending.

Member

ddfreyne commented Feb 16, 2017

I’ll merge this PR, as it is a step in the right direction. A proper fix, which involves being able to check the binary-ness of an item rep without needing it to be compiled first, is still pending.

@ddfreyne ddfreyne merged commit e64bf68 into master Feb 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the gh-1082 branch Feb 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment