Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require compilation before calling #binary? #1083

Merged
merged 1 commit into from Feb 16, 2017
Merged

Require compilation before calling #binary? #1083

merged 1 commit into from Feb 16, 2017

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Feb 8, 2017

Fixes part of #1082.

@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Feb 16, 2017

I’ll merge this PR, as it is a step in the right direction. A proper fix, which involves being able to check the binary-ness of an item rep without needing it to be compiled first, is still pending.

Loading

@ddfreyne ddfreyne merged commit e64bf68 into master Feb 16, 2017
1 check passed
Loading
@ddfreyne ddfreyne deleted the gh-1082 branch Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant