New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache rule memory calculator results #1140

Merged
merged 5 commits into from Mar 29, 2017

Conversation

Projects
None yet
1 participant
@ddfreyne
Member

ddfreyne commented Mar 29, 2017

This prevents the rule memories from being recalculated when it’s not necessary. Calculating the rule memory is fairly expensive, so this leads to a nice speedup.

The design of the way the rule memory is passed around is not ideal. The ItemRepRouter is the service that calculates the final rule memory, and it returns that, so that it can be reused elsewhere. This is weird because ItemRepRouter both returns something and modifies item reps. Anyway, something to refactor later.

ddfreyne added some commits Mar 29, 2017

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Mar 29, 2017

Member

Further refactoring and speed improvement is possible, but I will leave this to a separate PR.

I intend to remove #outdatedness_reason_for and #basic_outdatedness_reason_for first, in a separate PR, as these methods are no longer useful.

Member

ddfreyne commented Mar 29, 2017

Further refactoring and speed improvement is possible, but I will leave this to a separate PR.

I intend to remove #outdatedness_reason_for and #basic_outdatedness_reason_for first, in a separate PR, as these methods are no longer useful.

@ddfreyne ddfreyne merged commit 09c22a9 into master Mar 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the cache-memories branch Mar 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment