New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTML5 in relativize_paths + colorize_syntax #1153

Merged
merged 5 commits into from Apr 15, 2017

Conversation

Projects
None yet
1 participant
@ddfreyne
Member

ddfreyne commented Apr 14, 2017

Fixes #1152.

  • HTML5 support for :relativize_paths
  • HTML5 support for :colorize_syntax

@ddfreyne ddfreyne changed the title from Add :html5 type for relativize_paths to Support HTML in relativize_paths + colorize_syntax Apr 14, 2017

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Apr 14, 2017

Member

This is a dead end… Nokogiri’s serializer is the one that adds <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">, even when using a HTML5 parser.

Member

ddfreyne commented Apr 14, 2017

This is a dead end… Nokogiri’s serializer is the one that adds <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">, even when using a HTML5 parser.

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Apr 15, 2017

Member

Curious—It seems that #to_s does not add the meta tag, while #to_html does.

Edit: nevermind — not quite!

Member

ddfreyne commented Apr 15, 2017

Curious—It seems that #to_s does not add the meta tag, while #to_html does.

Edit: nevermind — not quite!

ddfreyne added some commits Apr 15, 2017

@ddfreyne ddfreyne changed the title from Support HTML in relativize_paths + colorize_syntax to Support HTML5 in relativize_paths + colorize_syntax Apr 15, 2017

@ddfreyne ddfreyne merged commit 7cab492 into master Apr 15, 2017

3 checks passed

codecov/patch 100% of diff hit (target 98.66%)
Details
codecov/project 98.66% (+<.01%) compared to 576a216
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the nokogumbo branch Apr 15, 2017

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Apr 15, 2017

Member

This is released as part of Nanoc 4.7.6 now.

Member

ddfreyne commented Apr 15, 2017

This is released as part of Nanoc 4.7.6 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment