Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ActionSequence immutable #1158

Merged
merged 7 commits into from Apr 16, 2017
Merged

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Apr 16, 2017

The goal of this PR is to make ActionSequence an immutable object, and move the code that builds action sequences into a separate object (ActionSequenceBuilder?), so that computed properties of ActionSequence can be cached (#serialize, specifically).

@ddfreyne ddfreyne force-pushed the recording-executor-without-constructor-arg branch from f0afcdb to eeb3000 Apr 16, 2017
@ddfreyne ddfreyne merged commit 6ac90fd into master Apr 16, 2017
3 checks passed
Loading
@ddfreyne ddfreyne deleted the recording-executor-without-constructor-arg branch Apr 16, 2017
@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Apr 16, 2017

CC @Fjan — This should bring down compilation speed a little more.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant