New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ActionSequence immutable #1158

Merged
merged 7 commits into from Apr 16, 2017

Conversation

Projects
None yet
1 participant
@ddfreyne
Member

ddfreyne commented Apr 16, 2017

The goal of this PR is to make ActionSequence an immutable object, and move the code that builds action sequences into a separate object (ActionSequenceBuilder?), so that computed properties of ActionSequence can be cached (#serialize, specifically).

ddfreyne added some commits Apr 16, 2017

ddfreyne added some commits Apr 16, 2017

@ddfreyne ddfreyne merged commit 6ac90fd into master Apr 16, 2017

3 checks passed

codecov/patch 100% of diff hit (target 98.65%)
Details
codecov/project 98.67% (+0.01%) compared to 0081dcc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the recording-executor-without-constructor-arg branch Apr 16, 2017

@ddfreyne

This comment has been minimized.

Show comment
Hide comment
@ddfreyne

ddfreyne Apr 16, 2017

Member

CC @Fjan — This should bring down compilation speed a little more.

Member

ddfreyne commented Apr 16, 2017

CC @Fjan — This should bring down compilation speed a little more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment