Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include xml:base attribute on feed element #1172

Closed
wants to merge 1 commit into from
Closed

Include xml:base attribute on feed element #1172

wants to merge 1 commit into from

Conversation

@cristoper
Copy link
Contributor

@cristoper cristoper commented Apr 29, 2017

The 'xml:base' attribute is used by feed readers to resolve relative URLs in the feed content. Without it, relative URLs in feeds generator by nanoc are broken.

The 'xml:base' attribute is used by feed readers to resolve relative
URLs in the feed content. Without it, relative URLs in feeds generator
by nanoc are broken.
@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Apr 30, 2017

Looks good, thanks!

I’ll add a test for it and merge it to master.

(FYI: The build was broken due to a problem with master (5d2146b and 5dd0a74, unrelated to your changes), which I’ve fixed now.)

Loading

@ddfreyne ddfreyne mentioned this pull request Apr 30, 2017
@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Apr 30, 2017

Merged!

Loading

@ddfreyne ddfreyne closed this Apr 30, 2017
@cristoper
Copy link
Contributor Author

@cristoper cristoper commented Apr 30, 2017

Thanks!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants