Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use GET, not HEAD, for external links #1179

Merged
merged 1 commit into from May 15, 2017

Conversation

Projects
None yet
2 participants
@ddfreyne
Copy link
Member

commented May 15, 2017

Fixes #1178.

This makes the external links checker always use GET rather than HEAD (and falling back to GET only on 405 Method Not Allowed), because using HEAD is not always reliable, sadly.

@dmathieu
Copy link

left a comment

❤️ thank you!

@ddfreyne ddfreyne merged commit b5642d9 into master May 15, 2017

2 of 3 checks passed

codecov/patch 33.33% of diff hit (target 98.7%)
Details
codecov/project 98.7% (-0.01%) compared to 4fc38f3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the get-no-head branch May 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.