Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle on item/layout collections #1191

Merged
merged 6 commits into from Jun 25, 2017

Conversation

Projects
None yet
1 participant
@ddfreyne
Copy link
Member

commented Jun 24, 2017

This records dependencies on @items and @layouts, in order prevent recompiling items that do not (directly or indirectly) depends on the item and layout collections.

Accessing anything from @items and @layouts will mark an item as outdated when an item or layout is added. Future work includes improving this, by e.g. storing the pattern used by #[] and #find_all.

@ddfreyne ddfreyne force-pushed the item-and-layout-collection-references branch 10 times, most recently from 3f3f03b to fa6b1f7 Jun 24, 2017

@ddfreyne ddfreyne force-pushed the item-and-layout-collection-references branch from fa6b1f7 to f693891 Jun 25, 2017

@ddfreyne ddfreyne force-pushed the item-and-layout-collection-references branch from 72e8a2b to 888bf78 Jun 25, 2017

@ddfreyne ddfreyne force-pushed the item-and-layout-collection-references branch from 8e5e67e to a2dc5cc Jun 25, 2017

@ddfreyne ddfreyne changed the title Record dependencies on item/layout collections Handle on item/layout collections Jun 25, 2017

@ddfreyne ddfreyne merged commit 22a632d into master Jun 25, 2017

3 checks passed

codecov/patch 99.35% of diff hit (target 98.68%)
Details
codecov/project 98.69% (+<.01%) compared to dd6d4e9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the item-and-layout-collection-references branch Jun 25, 2017

@ddfreyne

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2017

I missed the main term from the PR title:

Handle dependencies on item/layout collections

not

Handle on item/layout collections

:|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.