New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make item/layout collection dependencies finer-grained #1193

Merged
merged 4 commits into from Jul 1, 2017

Conversation

Projects
None yet
1 participant
@ddfreyne
Member

ddfreyne commented Jul 1, 2017

Dependencies on the item/layout collection are currently all-or-nothing. Any item that directly or indirectly accesses @items or @layouts will have a a dependency on the entire collection of items/layouts. This means that adding a new item or a new layout will cause these items to be marked as outdated, even if they won’t depend on that specific new layout.

This PR makes @items[] and @items.find_all (same for @layout) generate finer-grained dependencies, which only depend on a subset of the collection of items (or layouts). This way, adding a new item or layout is less likely to cause other items to be recompiled.

@ddfreyne ddfreyne merged commit 71584db into master Jul 1, 2017

3 checks passed

codecov/patch 99.27% of diff hit (target 98.69%)
Details
codecov/project 98.7% (+<.01%) compared to 29284da
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ddfreyne ddfreyne deleted the finer-doc-collection-dependencies branch Jul 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment