Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ItemRepSelector #1195

merged 1 commit into from Jul 15, 2017


None yet
1 participant
Copy link

commented Jul 15, 2017

This makes ItemRepSelector use a stack rather than a graph, which is faster and requires much less code.

Functionally identical.

@ddfreyne ddfreyne force-pushed the simpler-item-rep-selector branch 3 times, most recently from 2a8fb60 to e705c3d Jul 15, 2017

@ddfreyne ddfreyne force-pushed the simpler-item-rep-selector branch from dc0aadc to 3e8936f Jul 15, 2017

@ddfreyne ddfreyne merged commit 1d93b22 into master Jul 15, 2017

3 checks passed

codecov/patch 100% of diff hit (target 98.7%)
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +1.29% compared to 77c7d7a
continuous-integration/travis-ci/pr The Travis CI build passed

@ddfreyne ddfreyne deleted the simpler-item-rep-selector branch Jul 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.