Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen on 127.0.0.1, not 0.0.0.0, by default #1205

Merged
merged 1 commit into from Aug 22, 2017
Merged

Conversation

@ddfreyne
Copy link
Member

@ddfreyne ddfreyne commented Aug 20, 2017

nanoc view listens on all network interfaces by default, which is potentially problematic, as exposes the (compiled) Nanoc site to other devices.

This is a potential security issue.

@ddfreyne ddfreyne force-pushed the default-host-not-0000 branch from cd2cb3b to f7dc35c Aug 20, 2017
@ddfreyne
Copy link
Member Author

@ddfreyne ddfreyne commented Aug 20, 2017

CC @whitequark — this is what I mentioned in #1204.

Loading

@ddfreyne ddfreyne merged commit d8232fa into master Aug 22, 2017
3 checks passed
Loading
@ddfreyne ddfreyne deleted the default-host-not-0000 branch Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant